Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify localtime and oldtime's docs #626

Closed
wants to merge 2 commits into from

Conversation

quodlibetor
Copy link
Contributor

In response to #578, there really isn't anything Chrono can do to actually prevent the invalid
memory accesses in libc -- all we can do is tell people not to set env vars. In my experience and
from conversations surrounding this issue, setting env vars is rare and definitely just shouldn't
be done once the process has more than one thread running. Hopefully isn't an an awful burden on
users, either in terms of feature reduction or of security scanning.

@quodlibetor quodlibetor mentioned this pull request Nov 19, 2021
5 tasks
@nico-abram
Copy link

segfault or crash in other interesting ways would it not be better to explicitly mention data races and undefined behaviour?

If this is going to be accepted I feel like at the very least these functions should be deprecated and have unsafe counterparts.

@pitdicker
Copy link
Collaborator

I agree the docs should say something about the issue with reading the TZ environment variable and our history with RUSTSEC-2020-0159. But since it is fixed with #677 we should say something different from the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants