Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New formatting API #1196

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

pitdicker
Copy link
Collaborator

This has now reached a basic working state that might pass the CI. Not that it ever did on first try...
There still is a lot to do when it comes to documentation and tests, and I should write down which attempts didn't work out.
But this is a start 😄.

Note that this PR relies on some preparatory work that is not all split out yet. The interesting commits start at "Add method to validate an Item can be formatted with an input type".

See #1127. cc @kamadorueda

@pitdicker pitdicker force-pushed the formatting_spec branch 8 times, most recently from d4b1ef9 to f42855c Compare July 22, 2023 19:46
@pitdicker pitdicker force-pushed the formatting_spec branch 5 times, most recently from 3e5f101 to 39d6449 Compare July 27, 2023 17:41
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: Patch coverage is 83.42541% with 120 lines in your changes are missing coverage. Please review.

Project coverage is 91.27%. Comparing base (0cfc405) to head (6e08273).

❗ Current head 6e08273 differs from pull request most recent head 45d7f15. Consider uploading reports for the commit 45d7f15 to get more accurate results

Files Patch % Lines
src/format/formatting.rs 77.58% 65 Missing ⚠️
src/naive/datetime/mod.rs 58.82% 21 Missing ⚠️
src/naive/time/mod.rs 71.62% 21 Missing ⚠️
src/datetime/mod.rs 91.78% 6 Missing ⚠️
src/date.rs 0.00% 4 Missing ⚠️
src/format/mod.rs 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   91.80%   91.27%   -0.53%     
==========================================
  Files          37       37              
  Lines       18148    18552     +404     
==========================================
+ Hits        16661    16934     +273     
- Misses       1487     1618     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant