-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New formatting API #1196
base: main
Are you sure you want to change the base?
New formatting API #1196
Conversation
d4b1ef9
to
f42855c
Compare
3e5f101
to
39d6449
Compare
39d6449
to
c68d04d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 91.80% 91.27% -0.53%
==========================================
Files 37 37
Lines 18148 18552 +404
==========================================
+ Hits 16661 16934 +273
- Misses 1487 1618 +131 ☔ View full report in Codecov by Sentry. |
c68d04d
to
2aaa351
Compare
2aaa351
to
6e08273
Compare
6e08273
to
45d7f15
Compare
This has now reached a basic working state that might pass the CI. Not that it ever did on first try...
There still is a lot to do when it comes to documentation and tests, and I should write down which attempts didn't work out.
But this is a start 😄.
Note that this PR relies on some preparatory work that is not all split out yet. The interesting commits start at "Add method to validate an
Item
can be formatted with an input type".See #1127. cc @kamadorueda