Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls-v1-3 subdomain. #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c0r0n3r
Copy link

@c0r0n3r c0r0n3r commented Feb 18, 2021

This adds tls-v1-3 on port 1013, similar to how other protocol subdomains are implemented. Also adds the test to the dashboard.

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

This adds tls-v1-3 on port 1013, similar to how other protocol subdomains are implemented. Also adds the test to the dashboard.
@c0r0n3r c0r0n3r force-pushed the tls-v1-3-only-domain branch from f18e4c5 to 5c611a8 Compare February 18, 2021 23:02
@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lgarron
Copy link
Collaborator

lgarron commented Feb 19, 2021

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3. Have you been able to test this change using Docker?

@hellow554
Copy link

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3.

That's unfortunately correct. Version 1.10.3 is used, 1.13 is needed atleast.

Is there a reason not to update to the latest stable version 1.20?
It's not available in the default repo, but in the nginx repo. Maybe worth an update?

Maybe worth an update of the whole ubuntu from 16.04 to 20.04?

@onefreddy
Copy link

I join the topic, I think you need to quickly refresh your nginx.
I would like to see a working subdomain in the mode tls 1.3 only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants