Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an extended validation certificate #335

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

april
Copy link
Collaborator

@april april commented Feb 14, 2018

Here's the first go at it. It's a bit awkward, so feel free to let me know what you truly think. :)

@lgarron
Copy link
Collaborator

lgarron commented Feb 15, 2018

LGTM. You sure you want extended-validation instead of ev?
(I'd be fine with adding a redirect from the latter to the former.)

@april
Copy link
Collaborator Author

april commented Feb 15, 2018

I prefer to be verbose when possible, but I think adding a redirect seems like a fine idea. Lemme do that real quick.

@april
Copy link
Collaborator Author

april commented Feb 15, 2018

I initially added ev.__DOMAIN__ to the cert, but then I realized that it would complicate the process of acquiring the production EV cert.

As such, I decided to use the normal wildcard cert for the redirect. Also if you think http://ev.badssl.com/ should redirect immediately to https://extended-validation.badssl.com/, I can make that tweak.

@lgarron
Copy link
Collaborator

lgarron commented Feb 20, 2018

Still looks good to me!

As such, I decided to use the normal wildcard cert for the redirect. Also if you think http://ev.badssl.com/ should redirect immediately to https://extended-validation.badssl.com/, I can make that tweak.

I would slightly prefer http://ev.badssl.com/-> https://ev.badssl.com/ -> https://extended-validation.badssl.com/ but it doesn't sound super important.

@april april merged commit 0b1b3a2 into chromium:master Feb 20, 2018
@april
Copy link
Collaborator Author

april commented Feb 20, 2018

Made the slight tweak to reflect @lgarron's most recent feedback. Thanks, @lgarron!

@christhompson christhompson mentioned this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants