Specify union type in phpdoc #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisnharvey Have you had some time to have a look at this? It's only a small change. |
|
Apologies for the delay, and thanks for your contribution! |
|
Will tag a new version today. |
|
Awesome, thank you! |
|
@chrisnharvey Did you maybe forget to tag a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The php version constraint for this package is PHP ^7.4 | ^8.0.
Union types are however not supported in PHP 7.4.
My suggestion is to specify the union type in the doc block for now and drop support for PHP 7.4, when it is no longer supported in a few months from now: https://www.php.net/supported-versions.php