Skip to content

Commit

Permalink
flow: Upgrade to v0.126.
Browse files Browse the repository at this point in the history
As noted in a recent commit where we upgraded to Flow v0.125, we
don't usually bump the Flow version outside of a React Native
upgrade commit.

But I found that we could get v0.126 without any added Flow errors
in React Native code -- which is even better than the situation with
Flow v0.125, where we saw one Flow error in one file.

Being on v0.126 is nice because we'll finally be able to drop our
comments like "this should really be exact -- see note in
jsonable.js" on many objects with indexer properties, and make those
object types exact.

- That, in turn, will help us address zulip#3452 more productively
  ("Convert all object types to exact, or explicitly-inexact").

- Fixing zulip#3452 is really a prerequisite for taking
  facebook/react-native@050a7dd01 (switching on `exact_by_default`),
  which is on the path to the RN v0.64 upgrade.

[1] https://flow.org/en/docs/config/options/#toc-exact-by-default-boolean
  • Loading branch information
chrisbobbe authored and gnprice committed Mar 10, 2021
1 parent c666daf commit c4d2a37
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ module.file_ext=.json
module.file_ext=.ios.js

[version]
^0.125.0
^0.126.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"eslint-plugin-prettier": "^3.2.0",
"eslint-plugin-react": "^7.21.5",
"eslint-plugin-react-hooks": "^4.2.0",
"flow-bin": "^0.125.0",
"flow-bin": "^0.126.0",
"flow-coverage-report": "^0.6.0",
"flow-typed": "^2.4.0",
"immutable-devtools": "^0.1.5",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5621,10 +5621,10 @@ [email protected]:
glob "7.1.1"
load-pkg "^3.0.1"

flow-bin@^0.125.0:
version "0.125.1"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.125.1.tgz#7edbc71e7dc39ddef18086ef75c714bbf1c5917f"
integrity sha512-jEury9NTXylxQEOAXLWEE945BjBwYcMwwKVnb+5XORNwMQE7i5hQYF0ysYfsaaYOa7rW/U16rHBfwLuaZfWV7A==
flow-bin@^0.126.0:
version "0.126.1"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.126.1.tgz#2726595e1891dc35b379b5994627432df4ead52c"
integrity sha512-RI05x7rVzruRVJQN3M4vLEjZMwUHJKhGz9FmL8HN7WiSo66/131EyJS6Vo8PkKyM2pgT9GRWfGP/tXlqS54XUg==

flow-coverage-report@^0.6.0:
version "0.6.2"
Expand Down

0 comments on commit c4d2a37

Please sign in to comment.