(GH-442) always pass cache-location to choco

[mwallner]

Description

fixes GH-442 by always adding -cacheLocation to each Chocolatey call.

Related Issue

Fixes #442

Motivation and Context

every time you call Install-BoxstarterPackage -PackageName "$filename" additional subdirectories chocolatey\chocolatey are appended to $env:temp

env:temp=C:\Users\map\AppData\Local\Temp\chocolatey\chocolatey
env:temp=C:\Users\map\AppData\Local\Temp\chocolatey\chocolatey\chocolatey\chocolatey
env:temp=C:\Users\map\AppData\Local\Temp\chocolatey\chocolatey\chocolatey\chocolatey\chocolatey\chocolatey

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mwallner]

I yet have to update the documentation to reflect this change.

[ctmcisco]

Hello @mwallner and @pauby . Was this halted for some reason as it looked promising.
I am still using the following work around: https://david.gardiner.net.au/2018/07/boxstarter-and-chocolatey-tips.html but I was curious if anything has changed.

[flcdrg]

I'm assuming the = is optional when setting -cachelocation

[mwallner]

hey @ctmcisco , thanks for bringing this up again! 😄
basically I didn't remove the [WIP] tag b/c I wanted to reflect the change this PR brings in somewhere in the documentation / webpage. (and afaik Paul doesn't look at PRs that still have that [WIP] tag 😉 )
unfortunately this somehow got "lost" along the way...

thanks for approving @flcdrg - do you have an Idea where we could "update the documentation to reflect this change"?

[pauby]

(and afaik Paul doesn't look at PRs that still have that [WIP] tag 😉 )

Yeah, I ignore those and Draft PR's unless tagged on them.

do you have an Idea where we could "update the documentation to reflect this change"?

Do we need to update the docs - would this not be expected behaviour?

[mwallner]

Hey @pauby - I think this is ready to get merged / want to have it "out of the way" when my next (MUCH bigger) PR comes around ;-)

[mwallner]

this is obsolete when GH-479 gets merged in

[gep13]

This PR is no longer required, as this will be addressed in the new version of Chocolatey, which will be embedded in the v3 release.