Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-265) Disable reboot check for anything but install, uninstall & upgrade #404

Merged
merged 2 commits into from
Feb 18, 2020
Merged

(GH-265) Disable reboot check for anything but install, uninstall & upgrade #404

merged 2 commits into from
Feb 18, 2020

Conversation

mwallner
Copy link
Member

this should fix GH-265

@mwallner mwallner self-assigned this Sep 2, 2019
@mwallner mwallner requested a review from pauby September 2, 2019 07:11
@mwallner mwallner added the 1 - Ready Issue is accepted, milestone added and are ready to be worked on label Sep 2, 2019
@mwallner mwallner mentioned this pull request Sep 11, 2019
Closed
@mwallner
Copy link
Member Author

mwallner commented Oct 8, 2019

@pauby - just realized from the title .. maybe "uninstall" should also do the reboot checking?

@pauby
Copy link
Member

pauby commented Oct 8, 2019

That is a really good point @mwallner - in that case we need think about the update command too - it might be deprecated but it's still available for use.

pauby
pauby requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. As you said we need to take into account the uninstall command as well as the update command. Good catch!

Boxstarter.Chocolatey/Chocolatey.ps1 Show resolved Hide resolved
@pauby pauby changed the title GH-265 disable reboot check for anything but install & update (GH-265) Disable reboot check for anything but install & update Oct 9, 2019
@pauby pauby changed the title (GH-265) Disable reboot check for anything but install & update (GH-265) Disable reboot check for anything but install & upgrade Oct 9, 2019
@mwallner mwallner requested a review from pauby October 11, 2019 20:40
@pauby pauby changed the title (GH-265) Disable reboot check for anything but install & upgrade (GH-265) Disable reboot check for anything but install, uninstall & upgrade Feb 18, 2020
@pauby pauby merged commit 411515e into chocolatey:master Feb 18, 2020
@pauby
Copy link
Member

pauby commented Feb 18, 2020

Awesome work! Thanks for your contribution!

@mwallner mwallner deleted the GH-265 branch April 27, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby approved these changes

Assignees

@mwallner mwallner

Labels
1 - Ready Issue is accepted, milestone added and are ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boxstarter is not parsing Chocolatey pin and source parameters correctly
2 participants
@mwallner @pauby