[minor] Add ABI to public module, extmodule #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, note that this is intended to not conflict with a future syntax for parameters or type parameters which would look similar, but would be located after the module name and not placed on the module keyword. Spitballing: public module<v2> Foo<x: Int, y: String>: |
darthscsi
approved these changes
Jun 24, 2024
They do not. It would also create some complications if they did as a single public module could then have different conventions requiring using the convention as part of the resulting module's name (this would affect the ABI of the module name and not just expectations around its ports). |
Add a way to specify the port lowering ABI of a public module or an
external module. This uses syntax like the following:
public module<v1> Foo:
extmodule<v2> Bar:
This includes language that indicates that the "v1" ABI is used if no ABI
is specified. This makes this change fully backwards compatible with
older FIRRTL versions (and thereby a "minor" change).
Fixes #171.
Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/issue-171
branch
from
8e4a4c5 to
d38aee1
Compare
|
Absolute bikeshed: For the syntax, could we add a Java/Scala-style annotation syntax? Eg: @abi("v1")
public module Foo:
@abi("v2")
extmodule Bar: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to specify the port lowering ABI of a public module or an external module. This uses syntax like the following:
This includes language that indicates that the "v1" ABI is used if no ABI is specified. This makes this change fully backwards compatible with older FIRRTL versions (and thereby a "minor" change).
Fixes #171.