Loading bar should only appear on noticeable latency #27
Comments
ghost
assigned
chieffancypants
added a commit
that referenced
this issue
Dec 12, 2013
chieffancypants
added a commit
that referenced
this issue
Dec 12, 2013
chieffancypants
added a commit
that referenced
this issue
Dec 12, 2013
alexmingoia
added a commit
to alexmingoia/angular-loading-bar
that referenced
this issue
Jan 3, 2014
|
fixed the configuration... will try and wrap my head around the tests and update them this weekend. |
|
this isn't in bower yet, right? |
|
@luisrudge nope, not yet -- still working in a separate branch for now |
|
@alexmingoia you're cool if I merge your work into my branch right? I was gonna take a stab at the tests soon |
|
@chieffancypants Yes, please do :) |
chieffancypants
added a commit
that referenced
this issue
Jan 21, 2014
Added angular libs via bower so I don't have to do this again
chieffancypants
added a commit
that referenced
this issue
Jan 21, 2014
The extra $timout.flush() accounts for the latency threshold
chieffancypants
added a commit
that referenced
this issue
Jan 21, 2014
chieffancypants
added a commit
that referenced
this issue
Jan 21, 2014
|
This one should be all set guys. Let me know if you encounter any weirdness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The bar should only appear when there is noticeable latency. Displaying the bar on every XHR request gets repetitive, and serves very little purpose on those quick ~20ms calls.
This change will likely break lots of tests
The text was updated successfully, but these errors were encountered: