Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MAINT: separate layout from logic #2

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

jasmainak
Copy link

@chenghuzi can you take over? I have to task switch now ...

I think you can understand from the code what I am trying to do. There shouldn't be any "style" or "layout" hidden inside the logic.

@jasmainak jasmainak changed the title MAINT: separate layout from logic [WIP] MAINT: separate layout from logic Jul 21, 2022
@jasmainak
Copy link
Author

also separate out the simulation_status somewhere in this way:

simulation_status = {
   'not_running': '<div style='background:gray;padding-left:10px;color:white;'>Not running</div>',
   'running': <div style='background:orange;padding-left:10px;color:white;'>Running...</div>,
   'finished': '<div style='background:green;padding-left:10px;color:white;'>Simulation finished</div>'
}

@chenghuzi chenghuzi merged commit 06dd729 into chenghuzi:hnn_gui Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants