Merge pull request GoogleCloudPlatform#1671 from acpana/acpana/test-v…

…alue-type-llm tests: custom diff checks for llms
cheftako · May 8, 2024 · 1b48ee4 · 1b48ee4
2 parents 129aa5b + 08b5ab2
commit 1b48ee4
Show file tree

Hide file tree

Showing 11 changed files with 1,258 additions and 0 deletions.
diff --git a/tests/e2e/testdata/scenarios/direct/llm_custom_diff/value_type/SCENARIO_README.md b/tests/e2e/testdata/scenarios/direct/llm_custom_diff/value_type/SCENARIO_README.md
@@ -0,0 +1,3 @@
+For the LoggingLogMetric we want to treat `spec.metricDescriptor.labels[].valueType` and `spec.metricDescriptor.valueType` set to "STRING" or "" as the same value!
+
+In other words, we expect no further `POST`s onto the cloud provider if we change one of the values from "STRING" to "" or vice versa. Note `GET`s are find for the underlying controllers to get the "live" state of the API object.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		For the LoggingLogMetric we want to treat `spec.metricDescriptor.labels[].valueType` and `spec.metricDescriptor.valueType` set to "STRING" or "" as the same value!

		In other words, we expect no further `POST`s onto the cloud provider if we change one of the values from "STRING" to "" or vice versa. Note `GET`s are find for the underlying controllers to get the "live" state of the API object.