Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong method used in .map tests #1711

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix wrong method used in .map tests #1711

merged 1 commit into from
Feb 2, 2021

Conversation

Pustur
Copy link
Contributor

@Pustur Pustur commented Feb 1, 2021 •
edited
Loading

The added return is to prevent linter errors due to the rule array-callback-return (which is probably why the .map call was originally replaced with .each).

Closes #1705.

@Pustur
test: .map test was actually calling .each (#1705)
134c93a 
The added return is to prevent linter errors due to rule `array-callback-return`
@fb55 fb55 merged commit 456fbe5 into cheeriojs:main Feb 2, 2021
@fb55
Copy link
Member

fb55 commented Feb 2, 2021

Great find @Pustur, and thanks a lot for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test for .map method is actually calling .each method
2 participants
@Pustur @fb55