small parentsUntil fixes #1708
Merged
small parentsUntil fixes #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
5saviahv
commented
Feb 1, 2021
5saviahv
commented
- parentsUntil selector accepts multiple results.
- parentsUntil filter didnt filter
|
@5saviahv This is a great find, any reason you closed the PR? |
|
I was panicking when one of my tests fail. Turns out I had typo in tests and it wasn't even pushed github. I use some jquery tests against cheerio, but since some of them fail, I use them with custom Jest matcher preventing jest hang. I thought I made commit with my custom matcher. |
fb55
reviewed
Feb 7, 2021
|
Nice stuff! |
fb55
added a commit
that referenced
this pull request
Feb 11, 2021
Continuation of #1708, fixing up `untilNodes` for `{prev,next}Until`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.