Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lodash vulnerability #1499

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fixing lodash vulnerability #1499

merged 2 commits into from
Oct 1, 2020

Conversation

eklem
Copy link
Contributor

@eklem eklem commented Oct 1, 2020

What about this being v1.0.0-rc.4 ?

Test result (same as before lodash version bump):

  650 passing (1s)
  1 pending

@fb55 fb55 merged commit 77a739c into cheeriojs:v1.0.0 Oct 1, 2020
@fb55
Copy link
Member

fb55 commented Oct 1, 2020

Thanks @eklem!

@eklem
Copy link
Contributor Author

eklem commented Oct 1, 2020

No problem, @fb55. Happy to be of some help.

Would it be possible to do a npm publish too?

@fb55
Copy link
Member

fb55 commented Oct 2, 2020

I would want to include updates to my modules in the RC (that would be htmlparser2, as well as the new cheerio-select module). I'm wrapping up the last changes, the next RC should land soon after.

@eklem
Copy link
Contributor Author

eklem commented Oct 28, 2020

Any progress on the htmlparser2and cheerio-select, @fb55 ?

@fb55
Copy link
Member

fb55 commented Oct 29, 2020

cheeriojs/cheerio-select#2 is currently blocking. If this doesn't get resolved in the next two weeks, I will release the package under a different name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants