Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of .text() #1166

Closed
jugglinmike opened this issue Mar 18, 2018 · 0 comments · Fixed by #1564
Closed

Improve performance of .text() #1166

jugglinmike opened this issue Mar 18, 2018 · 0 comments · Fixed by #1564
Labels
To Do

Comments

@jugglinmike
Copy link
Member

We recently improved the correctness of the text() method in a way that degrades performance. Restoring the performance of that method will require a new feature in the domhandler project.

See gh-588 for more detail.
@jugglinmike jugglinmike mentioned this issue Mar 18, 2018
Merged
fb55 added a commit that referenced this issue Dec 15, 2020
@fb55
refactor: Use domhandler nodes directly
034ac5b 
Avoids unnecessary parser calls. Fixes #1166.

Allows us to drop lodash. Fixes #1506.
@fb55 fb55 mentioned this issue Dec 15, 2020
Merged
fb55 added a commit that referenced this issue Dec 20, 2020
@fb55
refactor: Use domhandler nodes directly
b13688f 
Avoids unnecessary parser calls. Fixes #1166.

Allows us to drop lodash. Fixes #1506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use domhandler nodes directly cheeriojs/cheerio
1 participant
@jugglinmike