-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert back pull request #396 #425
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose not revert those changes, but find a way to fix che-in-che development
It is a temporary solution. There are several higher priority issues that need to be resolved. It is more than a year Che become my primary development environment. And now my development environment is broken. |
@vitaliy-guliy
I'm still +1 to find a fix for che-in-che development instead of reverting those changes === |
3ad1775
to
764f650
Compare
I will leave the PR opened for some time until we fix the problem To apply changes from this PR as a temporary workaround I'm using the following command
|
Just adding context for additional interested parties because I also ran across this problem doing some proof-of-concept work while building for Linux on s390x. The 2.3.0 version of the (at)devfile package is now an ESM module vs a CommonJS module in 2.2.0, so the require statement generated by the transpiler in che-api/impl/k8s-service-impl is no longer valid as show in the pop up notification in the original comment. Least intrusive change to me was to use import("@devfile/api") where needed but honestly not familiar enough with the technologies to know the actual implications of making that change. |
Signed-off-by: Vitaliy Gulyy <[email protected]>
764f650
to
5695c8c
Compare
Update
|
What does this PR do?
It is a temporary solution.
Reverts back #396 as it become not possible to run che-code in the development mode
What issues does this PR fix?
Part of eclipse-che/che#23163
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder