Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert back pull request #396 #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Sep 27, 2024

What does this PR do?

It is a temporary solution.
Reverts back #396 as it become not possible to run che-code in the development mode

Screenshot from 2024-09-25 15-23-36

What issues does this PR fix?

Part of eclipse-che/che#23163

How to test this PR?

  • create a PR from che-code repository
  • update node dependencies, compile and then run che-code

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Copy link

github-actions bot commented Sep 27, 2024

Click here to review and test in web IDE: Contribute

@vitaliy-guliy vitaliy-guliy requested a review from svor September 27, 2024 13:45
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose not revert those changes, but find a way to fix che-in-che development

@vitaliy-guliy
Copy link
Contributor Author

I propose not revert those changes, but find a way to fix che-in-che development

It is a temporary solution.

There are several higher priority issues that need to be resolved.

It is more than a year Che become my primary development environment. And now my development environment is broken.

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Sep 27, 2024

@vitaliy-guliy
as far as I know:

I'm still +1 to find a fix for che-in-che development instead of reverting those changes
As a workaround we could use your changes locally at che-in-che development

===
btw - all jobs failed, so it looks like it's not enough just revert those changes - some adaptation is required

@vitaliy-guliy
Copy link
Contributor Author

I'm still +1 to find a fix for che-in-che development instead of reverting those changes As a workaround we could use your changes locally at che-in-che development

I will leave the PR opened for some time until we fix the problem

To apply changes from this PR as a temporary workaround I'm using the following command
(just share for someone who needs to run che-code in che)

git show 764f6502330d2f3a509b5fc1da90f6b02f81aa3c > /tmp/my-changes.patch
git apply /tmp/my-changes.patch

@mattgritter
Copy link

Just adding context for additional interested parties because I also ran across this problem doing some proof-of-concept work while building for Linux on s390x. The 2.3.0 version of the (at)devfile package is now an ESM module vs a CommonJS module in 2.2.0, so the require statement generated by the transpiler in che-api/impl/k8s-service-impl is no longer valid as show in the pop up notification in the original comment. Least intrusive change to me was to use import("@devfile/api") where needed but honestly not familiar enough with the technologies to know the actual implications of making that change.

@vitaliy-guliy
Copy link
Contributor Author

Update

git show 5695c8cb9cb085632fbde0beef950421c9b95af0 > /tmp/my-changes.patch
git apply /tmp/my-changes.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants