Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devfile walkthrough extension to built-ins #326

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Feb 1, 2024

What does this PR do?

Adds vscode devfile extension to built-ins.

Screenshot from 2024-02-01 12-46-15

Screenshot from 2024-02-01 12-46-34

Screenshot from 2024-02-01 12-47-06

! Please note my comment in PR devfile/vscode-walkthrough-extension#3 (comment)

There is a regression in VS Code.
I will provide a small test extension and file the issue to the VS Code.

What issues does this PR fix?

eclipse-che/che#21606

How to test this PR?

Copy link

github-actions bot commented Feb 1, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-326-dev-amd64

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-326-dev-amd64

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-326-amd64

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review February 1, 2024 10:58
@vitaliy-guliy vitaliy-guliy requested a review from ibuziuk February 1, 2024 10:59
@vitaliy-guliy vitaliy-guliy marked this pull request as draft February 1, 2024 13:28
Copy link

github-actions bot commented Feb 1, 2024

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-326-dev-amd64

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-326-dev-amd64

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-326-amd64

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review February 1, 2024 17:35
},
{
"name": "devfile.vscode-devfile",
"version": "0.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to understand why latest does not work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, using latest here would be the best solution

added comment here eclipse-che/che#21606 (comment)

@l0rd
Copy link
Contributor

l0rd commented Feb 2, 2024

Can we make the Devfile walkthrough appear in the welcome page? Ideally as the first Walkthrough.

@vitaliy-guliy
Copy link
Contributor Author

Can we make the Devfile walkthrough appear in the welcome page? Ideally as the first Walkthrough.

I wanted, but have not found a way how to do it. VS Code plugin API does not provide the ability to change item order. It seems VS Code displays the walkthrouhs due to order in which the extensions are loaded/added to the vscode.

@vitaliy-guliy vitaliy-guliy merged commit a26b438 into main Feb 5, 2024
6 checks passed
@vitaliy-guliy vitaliy-guliy deleted the add-devfile-extension branch February 5, 2024 12:57
@devstudio-release
Copy link

Build 3.13 :: code_3.x/1270: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: code_3.12/15: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: get-sources-rhpkg-container-build_3.x/6091: FAILURE

code : 3.x :: Failed in 58688859 : code-rhel8-3.13-10
FAILURE: 1158568 - osbs.osbs_http - DEBUG - cleaning up==> 58688859:DEFAULT:osbs-build.log: <==; copied to quay

@devstudio-release
Copy link

Build 3.12 :: get-sources-rhpkg-container-build_3.12/51: FAILURE

code : 3.12 :: Failed in 58688860 : code-rhel8-3.12-61
FAILURE: 1158575 - osbs.osbs_http - DEBUG - cleaning up==> 58688860:DEFAULT:osbs-build.log: <==; copied to quay

@vitaliy-guliy vitaliy-guliy added the made-with-che Changes made with Che-Code label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes made with Che-Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants