Support vscode --default-workspace option
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <[email protected]>
l0rd
requested review from
azatsarynnyy,
RomanNikitenko and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ |
azatsarynnyy
approved these changes
May 25, 2023
|
Pull Request images published ✨ |
azatsarynnyy
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Support vscode `--default-workspace` option Signed-off-by: Mario Loriedo <[email protected]>
azatsarynnyy
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Support vscode `--default-workspace` option Signed-off-by: Mario Loriedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows to specify a VS Code workspace file through the env variable
VSCODE_DEFAULT_WORKSPACEWhat issues does this PR fix?
eclipse-che/che#22218
How to test this PR?
For Che 7.64 or higher and Dev Spaces 3.6 or higher I have created the following gist with a VS Code spec that uses image
quay.io/mloriedo/che-code:insidersand that can be tested using the following URL:<che-host>/#<repo-url>?che-editor=https://gist.githubusercontent.com/l0rd/d970c5ac4fc66aa3b7162360d3efee85/raw/7f0a93164896a4c2b28971ba7cccc3238b8857b5/che-code.yamlThis link allows testing on dogfooding instance.