Expose animation default interpolators to use in custom implementation #11129
Conversation
|
I'm not TS expert (very low skill, apologize) therefore not sore if the TS is 100% correct |
Co-authored-by: Dan Onoshko <[email protected]>
stockiNail
requested review from
dangreen and
kurkle
and removed request for
dangreen and
kurkle
| @@ -20,7 +20,8 @@ const chart = new Chart('id', { | |||
| delay: (ctx) => ctx.dataIndex * 100, | |||
| duration: (ctx) => ctx.datasetIndex * 1000, | |||
| loop: true, | |||
| easing: 'linear' | |||
| easing: 'linear', | |||
| fn: (from: any, to: any, factor: number) => ({size: Animation.interpolators.number(0, 32, factor)} as any) | |||
There was a problem hiding this comment.
this is a really bad test, animating numbers a, and b and resulting to an object value.
I would argue it would be better to fix the options resolution for font in the use case and just animate the size as a number.. and not support animation objects, because its going to open deep can of worms.
There was a problem hiding this comment.
That said, I'm not against this PR itself. I'd even maybe make the interpolators writable, if that can be supported.
There was a problem hiding this comment.
@kurkle when you wrote ‘writable’ do you mean custom interpolator for custom type?
There was a problem hiding this comment.
this is a really bad test, animating numbers a, and b and resulting to an object value.
@kurkle this is just a test for the OOTB interpolators. I can add a specific test for objects but I didn't want to add another test case because fn was used here.
I would argue it would be better to fix the options resolution for font in the use case and just animate the size as a number.. and not support animation objects, because its going to open deep can of worms.
@kurkle I could agree with you but, afai understood, fn option was born for this reason, to give to the user the possibility to animate items not manageable OOTB (like objects). If there is this option for other purposes, it's not clear to me.
About font, this is not really my use case. The use case is coming from annotation plugin where, having color option aa an array, the animation doesn't recognize the array, therefore I was thinking to have a specific animation for color where, when configured as an array, the custom interpolator will return an array of intepolated colors.
The best solution could be to enable animation on inner nodes of the options (like font, padding, borders and other), where the property is defined by dot separator. Something like:
properties: ['font.size', 'padding.top'],But I think this deserve a specific PR, this one is just to expose the OOTB interpolator.
Let me know how to proceed.
|
I think I have found another way. I close it in the meantime. |
This PR is exposing the out-of-the-box animation interpolators in order to enable the user to use them in a custom interpolator.
See #11118 (comment)