Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prosopite.enabled and introduce Rack and Sidekiq middleware. #69

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented Sep 15, 2023

  • Add Prosopite.enabled option to enable or disable prosopite across the entire application (this option defaults to true.
  • Introduce a rack and sidekiq middleware to help use Prosopite.

@dhruvCW dhruvCW changed the title Add Prosopite.disable and introduce Rack and Sidekiq middleware. Add Prosopite.enable and introduce Rack and Sidekiq middleware. Sep 16, 2023
Copy link
Owner

@charkost charkost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhruvCW!
Could you also update the README with instructions on how to use the middlewares & description for the enabled ?

lib/prosopite.rb Outdated Show resolved Hide resolved
the option helps disable or enable Prosopite based on the
environment without requiring changes to the implementation stack.

By default this option is set to true.
@dhruvCW dhruvCW changed the title Add Prosopite.enable and introduce Rack and Sidekiq middleware. Add Prosopite.enabled and introduce Rack and Sidekiq middleware. Sep 23, 2023
@dhruvCW
Copy link
Contributor Author

dhruvCW commented Sep 23, 2023

Thanks @dhruvCW! Could you also update the README with instructions on how to use the middlewares & description for the enabled ?

yup just updated the Readme and changed enable to enabled 👍

@dhruvCW dhruvCW requested a review from charkost September 23, 2023 09:01
@dhruvCW
Copy link
Contributor Author

dhruvCW commented Sep 23, 2023

@charkost would it be possible for a new release to be published once this PR is merged ?

@charkost charkost merged commit 1dedef8 into charkost:main Sep 26, 2023
4 checks passed
@dhruvCW dhruvCW deleted the middleware branch September 26, 2023 12:57
@charkost
Copy link
Owner

@dhruvCW Ready - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants