Unblock CI #3854
Merged
Unblock CI #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
approved these changes
Oct 2, 2017
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
5ba9f6b to
2d12a5b
Compare
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
2d12a5b to
c5aeef9
Compare
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
c5aeef9 to
6de61c6
Compare
MSLaguana
reviewed
Oct 3, 2017
netci.groovy
Outdated
| @@ -124,7 +124,7 @@ def CreateXPlatBuildTask = { isPR, buildType, staticBuild, machine, platform, co | |||
| def staticFlag = staticBuild ? "--static" : "" | |||
| def swbCheckFlag = (platform == "linux" && buildType == "debug" && !staticBuild) ? "--wb-check" : ""; | |||
| def icuFlag = (platform == "osx" ? "--icu=/usr/local/opt/icu4c/include" : "") | |||
| def compilerPaths = (platform == "osx") ? "" : "--cxx=/usr/bin/clang++-3.8 --cc=/usr/bin/clang-3.8" | |||
| def compilerPaths = (platform == "osx") ? "" : "--cxx=/usr/bin/clang++-3.9 --cc=/usr/bin/clang-3.9" | |||
There was a problem hiding this comment.
I thought this change was already in 1.6?
There was a problem hiding this comment.
You are correct; my local release/1.6 was out of date. I've updated and rebased the PR on top of the current release/1.6 branch.
MSLaguana
approved these changes
Oct 3, 2017
jianchun
approved these changes
Oct 3, 2017
|
The ubuntu shared_ubuntu_linux_debug failure is due to the libclang-3.9-dev package missing on the machines, and @mmitche is updating that for us. |
This was previously used in the hybrid debugging scenario (VS would set a breakpoint on this function, which was hard to inline). Since this is no longer supported, we can remove this function.
Prefast started complaining about these; as far as I can tell, they are false positives. The analysis asserts should silence the error.
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
48a7850 to
2b399be
Compare
digitalinfinity
approved these changes
Oct 3, 2017
This is a bit weird... I'm going to follow up with the PREfast team about this warning.
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
817d35d to
8be4344
Compare
Previous attempts to silence this have failed; going to a pragma for now.
Penguinwizzard
force-pushed
the
remove_mfeds
branch
from
8be4344 to
027f23b
Compare
|
@mmitche is there a known timeline for the package addition? If it's going to be a bit, I'd like to send this set in and temporarily disable the failing flavor. |
|
@Penguinwizzard At least another hour or two. |
|
@mmitche Ok, I'll disable the flavor then, and open a PR to re-enable it. |
The proper fix for this is going to come in a couple hours once the CI has the right libraries again; this change is temporary.
chakrabot
pushed a commit
that referenced
this pull request
Oct 3, 2017
Merge pull request #3854 from Penguinwizzard:remove_mfeds ## Remove MarkerForExternalDebugStep This was previously used in the hybrid debugging scenario (VS would set a breakpoint on this function, which was hard to inline). Since this is no longer supported, we can remove this function. ## Add analysis asserts to silence false positives Prefast started warning on some false positives. This silences them. ## Pull in Jimmy's changes to fix xplat CI Xplat build machines now have clang3.9, we need to support that.
chakrabot
pushed a commit
that referenced
this pull request
Oct 3, 2017
Merge pull request #3854 from Penguinwizzard:remove_mfeds ## Remove MarkerForExternalDebugStep This was previously used in the hybrid debugging scenario (VS would set a breakpoint on this function, which was hard to inline). Since this is no longer supported, we can remove this function. ## Add analysis asserts to silence false positives Prefast started warning on some false positives. This silences them. ## Pull in Jimmy's changes to fix xplat CI Xplat build machines now have clang3.9, we need to support that.
chakrabot
pushed a commit
that referenced
this pull request
Oct 3, 2017
Merge pull request #3854 from Penguinwizzard:remove_mfeds ## Remove MarkerForExternalDebugStep This was previously used in the hybrid debugging scenario (VS would set a breakpoint on this function, which was hard to inline). Since this is no longer supported, we can remove this function. ## Add analysis asserts to silence false positives Prefast started warning on some false positives. This silences them. ## Pull in Jimmy's changes to fix xplat CI Xplat build machines now have clang3.9, we need to support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MarkerForExternalDebugStep
This was previously used in the hybrid debugging scenario (VS would
set a breakpoint on this function, which was hard to inline). Since
this is no longer supported, we can remove this function.
Add analysis asserts to silence false positives
Prefast started warning on some false positives. This silences them.
Pull in Jimmy's changes to fix xplat CI
Xplat build machines now have clang3.9, we need to support that.