fix(swap): validate total liquidity for non dca quotes #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 100 100
Lines 1351 1351
Branches 207 207
=======================================
Hits 1176 1176
Misses 166 166
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Comment on lines
+264
to
+267
| } else if (quote) { | ||
| await validateLiquidity(quote.egressAmount, quote.intermediateAmount); | ||
| } else { | ||
| throw ServiceError.internalError('could not generate quotes'); |
There was a problem hiding this comment.
i think we should always do this for all of the quotes, no?
Suggested change
| } else if (quote) { | |
| await validateLiquidity(quote.egressAmount, quote.intermediateAmount); | |
| } else { | |
| throw ServiceError.internalError('could not generate quotes'); | |
| } | |
| if (quote) { | |
| await validateLiquidity(quote.egressAmount, quote.intermediateAmount); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.