Fix sm integration #191
Fix sm integration #191
Conversation
kylezs
commented
Jun 25, 2021
•
kylezs
commented
|
Currently blocked due to an issue with ganache. I can't solve the issue with this happening consistently: When calling |
| sudo apt install nodejs | ||
| sudo apt-get update | ||
| sudo apt install npm | ||
| sudo npm install -g ganache-cli |
There was a problem hiding this comment.
FWIW these instructions will only work on linux distros with apt, and most of us use macOS 😉
There was a problem hiding this comment.
I didn't know so many used Mac, Still better then no setup instructions? Maybe i should mention that the instructions are for Linux distros like Ubuntu.
| - [Script](https://github.com/chainflip-io/chainflip-eth-contracts/blob/master/scripts/deploy_and.py) that creates the events expected by the test | ||
| ```sh | ||
| sudo apt-get install pip | ||
| pip install eth-brownie |
There was a problem hiding this comment.
In the eth-contracts repo we use poetry as a dependency manager to prevent conflicts, maybe it would be worth copying the install instructions from there for the ETH part of this install process?
There was a problem hiding this comment.
I did read those instructions when i was trying to get this working, but because the setup.sh downloads poetry automatically, i didn't add it to the instructions. Maybe its worth a mentions though.
|
@j4m1ef0rd I'm not sure if you chatted with Kyle about it beforehand, but usually I would prefer we don't commit directly to each others' branches, even if it is only to update a README. Exceptional circumstances might change this policy. Is there a reason you didn't make a PR? |
|
@morelazers I didn't know that this draft PR existed. I was working a little with kyle, I thought my job was to clean up what was in this branch and get it into develop, even if the test still didn't work. Am I not doing this the right way? |
