Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to Chai version 2.2.0 #84

Closed
wants to merge 1 commit into from
Closed

Updated documentation to Chai version 2.2.0 #84

wants to merge 1 commit into from

Conversation

aaronsofaly
Copy link
Contributor

I updated the documentation to match Chai version 2.2.0.

I noticed there were some changes in the /chai/lib/chai/core/assertions.js file that have not yet made it to /chai/chai.js. So I did not add that to the documentation. The changes include some trailing whitespace fixes and an addition of an .ownPropertyDescriptor() method.

@keithamus
Copy link
Member

Thanks @aaronsofaly, but I'm going to close this one, here's why:

The website is not catching up as fast as the codebase right now, because its a bit of a pain to deploy. We're working on this and hope to have the website managed via a simpler mechanism (probably GH-pages) soon. Follow #34 and #74 for more info, and feel free to help out if you can.

I'm also going to close this PR as a way to draw a line in the sand - while I could merge it, it's not going to help the situation (although it doesn't hurt it) - but by closing it and other similar PRs, hopefully it sends a message that you (and others) are better off spending time improving chai, or working on #34/#74.

So please don't take it to heart, and please, if you do have time, help us with #34/#74 - it'll be much for valuable for the long game.

@keithamus keithamus closed this Apr 20, 2015
@aaronsofaly
Copy link
Contributor Author

@keithamus No worries, understood.

I'll watch this project and help out where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants