Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chai Immutable in the plugins #79

Merged
merged 1 commit into from
Mar 9, 2015

Conversation

astorije
Copy link
Member

@astorije astorije commented Mar 9, 2015

At the time of sending this PR, Chai Immutable is v0.2.1 and will evolve, maybe without keeping BC depending on the feedback I have. But I already saw some people showing interest in the plugin and I figured I should rather share it sooner than later.

Also, I haven't done anything towards browser support yet but it is planned as Immutable itself has browser support.

Let me know if you have any other quality requirements to follow to get this accepted and I'll do my best to comply with them ASAP.

keithamus added a commit that referenced this pull request Mar 9, 2015
@keithamus keithamus merged commit b50b77a into chaijs:master Mar 9, 2015
@keithamus
Copy link
Member

👍

@astorije astorije deleted the astorije/chai-immutable-plugin branch March 9, 2015 15:57
@astorije
Copy link
Member Author

astorije commented Mar 9, 2015

Thanks @keithamus!

Would you allow me to 1) sort the plugins alphabetically 2) filter out some tags, as the list of tags on the left of the plugin page doesn't even fit my 1080p screen! If so, do you think we could come up with a list of tags maybe?

@keithamus
Copy link
Member

Quite frankly @astorije it might not be worth your time, as #34 discusses refactoring the plugins page, which may do away with plugins.js.

If you're interested in this area though, please feel free to help out in #34 with coming up with a reasonable solution 😄

@astorije
Copy link
Member Author

Thanks for the heads-up, @keithamus! It sounds like an interesting project, but I'm afraid I'm gonna pass on that given other (multiple!) priorities. I'll stay tuned though.

@astorije
Copy link
Member Author

@keithamus, now that it is merged, do you know when it is going to make it live?
Also, how often does it get refreshed? Since I plan to release new versions frequently until it is stable, I'm wondering how "unfresh" the plugin page will be since its content is hard-coded and not loaded with Ajax or something.

@keithamus
Copy link
Member

Sorry @astorije. It requires manual updating, by @logicalparadox who has little free time, as such I can give no estimate, but kindly ask you have patience. As for how fresh it'll be when it's released - when we resolve #34 this wont be an issue, so if you have any ideas toward solving it we thoroughly welcome it 😄

@astorije
Copy link
Member Author

Of course re: patience! Was just trying to ping, nothing more :-)

Good luck with #34 😉

@astorije
Copy link
Member Author

astorije commented Jun 2, 2015

@logicalparadox, any chance the update can happen sometime soon? FYI, my plugin is now in version 1.0.0. Thanks!

@keithamus
Copy link
Member

We're working on converting the Chai site to Jekyll pages (literally as I speak), so updates are automatic. It'll just take some time - it's a big change. I hope it'll be done in the coming weeks.

@astorije
Copy link
Member Author

astorije commented Jun 3, 2015

Nice, good luck with that! :-)
If it ends up taking more than expecting, it might be nice to update the main docs, maybe, because I feel like they are getting pretty outdated.
KUTGW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants