-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify types on increase | decrease #796
Conversation
Round 2! (LGTM!) |
@@ -1961,7 +1961,7 @@ module.exports = function (chai, _) { | |||
/** | |||
* ### .increase(function) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the docs for this could use another name for the argument being passed other than function
.
Good job @vieiralucas, especially regarding the tests 😄 |
Nice one! |
eec569e
to
508f8b1
Compare
Hi @vieiralucas, thanks for the corrections, good job noticing the
Since this PR tackles all those methods maybe we could do all these fixes right here, what do you think? Also, sorry for not adding comments to lines and for not seeing this before, unfortunately github only allows me to comment lines which have been changed (or are very very near the changes). |
508f8b1
to
b0fb817
Compare
@lucasfcosta You have very good eyes 😄 I definitely agree with the things you have said. Thanks again |
Indicate that 'property' and 'message' are optional. Indicate that 'increase' and 'decrease' can receive a function which returns the property to be checked.
b0fb817
to
5f3c4ae
Compare
LGTM! |
LGTM! |
\o/ Does that means that #691 can be closed? |
Yes it does! Thanks for noticing 👍 |
Hello there again!
I saw that @meeber did a very good job and now chai 4.x.x is finally merged at master.
So here am I, aiming to solve the rest of #691.
This PR aims to check that the property being tested by increase | decrease is a number.
It also adds tests to
assert.atLeast
andassert.atMost
since after the merge they automatically started to check types.I don't know if I'm happy with the documentation changes, so please give your opinions on that.
Thank You