-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .deep.include
for deep equality comparisons
#761
Conversation
Okay, this is all good. @lucasfcosta if you want to, we can just review this one and close #744, #757, #758, and #760, or alternatively merge each one in order. |
@keithamus I'd prefer reviewing each one separately. It looks better to me since they are different small changes regarding different things, even though they depend on each other. Before continuing my review of each one of those, I added comments to the first two PRs I reviewed regarding the branch these changes are going into, shouldn't they be going to |
- Previously, `.include` was using strict equality for non-negated property inclusion, but deep equality for negated property inclusion and array inclusion. This fix causes `.include` to always use strict equality.
@keithamus @lucasfcosta Pushed new version! |
LGTM! |
@lucasfcosta Thanks for reviewing :D |
LGTM 👍 |
Notes:
.not.property(name, val)
behavior #744, Breaking: Rename.deep.property
to.nested.property
#757, Add.deep.property
for deep equality comparisons #758, and Breaking: Fix.include
to always use strict equality #760 are prerequisites for this PR. I recommend reviewing them first, and then only reviewing the newest commit in this PR.