Throw when calling _super on overwriteMethod if method is undefined

[wbyoung]

This fixes #467.

[keithamus]

👍 thanks @wbyoung

[wbyoung]

@keithamus sure thing. Sorry for such a long delay between submitting the issue & sending a PR — life's been busy.

[keithamus]

Can totally respect that. Thank you for taking the time to do it! I'll let you know when it is released 😄

[electricmonk]

This is awesome.
I'd very much like to see a change in documentation to encourage plugin authors to respect and share namespaces, like @wbyoung mentions in #467

[keithamus]

@electricmonk yeah, that is a great point. Care to make a PR for it? All of the plugin guides in Chaijs.com are markdown files here on the chai-docs repo. Please, if you have any insight to put in to the guides (which I'm sure you do), then I encourage you to make a PR 😄

[electricmonk]

@keithamus Shall I make the PR to the 4.x.x branch?
In general, I would suggest deprecating addMethod and addProperty and only allowing a single interface for registering matchers. But this is a breaking change that would have to be gradually introduced.

[keithamus]

@electricmonk

Shall I make the PR to the 4.x.x branch?

Yes please!

In general, I would suggest deprecating addMethod and addProperty and only allowing a single interface for registering matchers. But this is a breaking change that would have to be gradually introduced.

Yup, totally. Have a look at #457 which makes small mention of that, you can also see #117 (comment) for some sketching on what a simpler plugin system would look like. I have some more code on my machine but I want to hash out a sensible design before we properly dive into that kind of refactoring. I think I'd like to see us have no "plugin interface", and plugins just export an object of methods which return assertion errors or something similar.

[electricmonk]

Hmm. @keithamus, the chai-docs repo doesn't seem to have a 4.x.x branch, shall I create it?

[keithamus]

@electricmonk sorry, for the chai-docs repo if you could please take a look at the gh-pages branch, which is effectively inline with 4.x.x (or, at least, they'll probably be released around the same time).

[electricmonk]

hey, @keithamus -
Currently the documentation for building a plugin starts from describing addProperty and addMethod, and then describes the overwrite... methods. My thoughts are to deprecate the add... methods in the documentation, so that they are mentioned at the end as backwards-compatibility relics, and focus on overwriteMethod and overwriteProperty.

However, since this means a major overhaul of the helpers page, I thought I'd better ok it with you first. So - are you ok with this? :)

[keithamus]

@electricmonk I'd rather focus energy on #585. Also I'm not sure overwriteMethod is the one canonical property; it's more complex than addMethod, which will still work for the majority of use cases.

[electricmonk]

@keithamus so what should be the scope for my docs PR? maybe a note at the top of the page, in the spirit of

Note: the plugin API is pending a major overhaul in future versions of Chai. In the meantime, please prefer overwriteMethod to addMethod for the sake of sharing plugin namespaces.

[keithamus]

yes that might be a good idea, thanks.

[electricmonk]

@keithamus It appears that the helpers page in the gh-pages branch doesn't have the addMethod section (although it appears in the ToC). Is that intentional?

[keithamus]

That certainly isn't intentional, the gh-pages site is a work in progress, so its likely something that got missed. If you could so kindly add it back in that'd be swell 😄