Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use levenshtein distance to suggest alternatives in proxy mode #771

Closed
keithamus opened this issue Aug 15, 2016 · 0 comments · Fixed by #782
Closed

Use levenshtein distance to suggest alternatives in proxy mode #771

keithamus opened this issue Aug 15, 2016 · 0 comments · Fixed by #782

Comments

@keithamus
Copy link
Member

We should use the levenshtein distance algo to determine correct properties to use as suggestions in the errors for unknown properties - when using proxies.

For example

expect(true).to.be.ture
// Error: unknown property .ture

Could be

expect(true).to.be.ture
// Error: unknown property .ture, did you mean .true?
not-an-aardvark added a commit to not-an-aardvark/chai that referenced this issue Sep 4, 2016
@not-an-aardvark
Add fix suggestions when accessing a nonexistent property in proxy mode
f045a57 
fixes chaijs#771
@not-an-aardvark not-an-aardvark mentioned this issue Sep 4, 2016
Merged
not-an-aardvark added a commit to not-an-aardvark/chai that referenced this issue Sep 8, 2016
@not-an-aardvark
Add fix suggestions when accessing a nonexistent property in proxy mode
e8085b0 
fixes chaijs#771
lucasfcosta pushed a commit to lucasfcosta/chai that referenced this issue Sep 15, 2016
@not-an-aardvark @lucasfcosta
Add fix suggestions when accessing a nonexistent property in proxy mode
188501f 
fixes chaijs#771
@lucasfcosta lucasfcosta mentioned this issue Oct 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fix suggestions when accessing a nonexistent property in proxy mode not-an-aardvark/chai
1 participant
@keithamus