Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting "does" as a no-op assertion #700

Closed
ddevault opened this issue May 6, 2016 · 3 comments
Closed

Requesting "does" as a no-op assertion #700

ddevault opened this issue May 6, 2016 · 3 comments
Labels
feature-requests fun-size pull-request-wanted

Comments

@ddevault
Copy link

ddevault commented May 6, 2016 

expect(foobar).to.have.property("baz").which.does.not.have.property("thing");
@meeber
Copy link
Contributor

meeber commented May 6, 2016

Sounds reasonable to me.

@lucasfcosta
Copy link
Member

Sounds good to me too, I've thought about this myself when analyzing other issues, I think this one is totally valid.

vieiralucas added a commit to vieiralucas/chai that referenced this issue May 6, 2016
@vieiralucas
Add .does as a no-op assertion, Fix chaijs#700
4049af6
@vieiralucas vieiralucas mentioned this issue May 6, 2016
Merged
vieiralucas added a commit to vieiralucas/chai that referenced this issue May 7, 2016
@vieiralucas
Add .does as a no-op assertion, Fix chaijs#700
adcbb0b
vieiralucas added a commit to vieiralucas/chai that referenced this issue May 7, 2016
@vieiralucas
Add .does as a no-op assertion, Fix chaijs#700
d43287f
vieiralucas added a commit to vieiralucas/chai that referenced this issue May 7, 2016
@vieiralucas
Add .does as a no-op assertion, Fix chaijs#700
16fb110
lucasfcosta added a commit that referenced this issue May 7, 2016
@lucasfcosta
Merge pull request #701 from vieiralucas/does
8e781c4 
Add .does as a no-op assertion, Fix #700
@ddevault
Copy link
Author

ddevault commented May 8, 2016

Thanks!

@lucasfcosta lucasfcosta mentioned this issue Sep 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-requests fun-size pull-request-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddevault @lucasfcosta @meeber