-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with chai 4? #47
Comments
... to circumvent a problemn with chai 4 and chai-json-schema - see chaijs/chai-json-schema#47 for more info
A PR would be welcome IMO, but you should get a consensus from the rest of the @chaijs/chai-json-schema team |
Hi @sverweij, I'm okay with you going ahead to fix the dependency versions. Feel free to create a PR. Regarding the other items in the TODO list in issue #26. They're not really high priority because everything works well enough. We won't be spending too much time on it. However, should you feel inclined to help out, then those items could certainly use some attention. |
👍 see ☝️ |
Hi @JrSchild - thanks for maintaining this chai plugin. It's very useful and should be a mandatory consideration for any project doing stuff with json and chai.
I've recently upped chai to version 4, and when installing chai-json-schema npm warns
The package [email protected] does not satisfy its siblings' peerDependencies requirements!
(see travis jobs 99.1 - 99.3 and the PR greenkeeper made to up chai).On npm versions < 3 (those distributed with node 4 and 0.x) this breaks any build using chai-json-schema.
I've forked chai-json-schema, changed the
chai
peerDependencies range to>= 1.6.1 < 5
, upped thechai
dependency to 4.0.2 and ran the test suite => works OK.The text was updated successfully, but these errors were encountered: