Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with chai 4? #47

Closed
sverweij opened this issue Jun 24, 2017 · 3 comments
Closed

Not compatible with chai 4? #47

sverweij opened this issue Jun 24, 2017 · 3 comments

Comments

@sverweij
Copy link
Contributor

Hi @JrSchild - thanks for maintaining this chai plugin. It's very useful and should be a mandatory consideration for any project doing stuff with json and chai.

I've recently upped chai to version 4, and when installing chai-json-schema npm warns The package [email protected] does not satisfy its siblings' peerDependencies requirements! (see travis jobs 99.1 - 99.3 and the PR greenkeeper made to up chai).

On npm versions < 3 (those distributed with node 4 and 0.x) this breaks any build using chai-json-schema.

I've forked chai-json-schema, changed the chai peerDependencies range to >= 1.6.1 < 5, upped the chai dependency to 4.0.2 and ran the test suite => works OK.

  1. Would you be willing to either make these changes or accept mine as a pull request?
  2. In Roadmap next major release (v2.0?) #26 I see there's some chores for this project that need doing. I'm willing to pick up some of these + the request @keithamus has for changing some build/ code quality tooling to chaijs guidelines. Would you be OK with that?
sverweij added a commit to sverweij/dependency-cruiser that referenced this issue Jun 24, 2017
... to circumvent a problemn with chai 4 and chai-json-schema - see chaijs/chai-json-schema#47 for more info
@keithamus
Copy link
Member

A PR would be welcome IMO, but you should get a consensus from the rest of the @chaijs/chai-json-schema team

@JrSchild
Copy link
Member

Hi @sverweij, I'm okay with you going ahead to fix the dependency versions. Feel free to create a PR.

Regarding the other items in the TODO list in issue #26. They're not really high priority because everything works well enough. We won't be spending too much time on it. However, should you feel inclined to help out, then those items could certainly use some attention.

@sverweij
Copy link
Contributor Author

👍 see ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants