-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Chai v4.0 #105
Update for Chai v4.0 #105
Conversation
@keithamus I've updated this PR for the Chai 4.0 release. Although Chai v4.0 is now a dependency for the test suite (due to changes in failed assertion message text), the library should still support older versions of Chai. |
LGTM but I'd like someone from @chaijs/chai-jquery to approve this too. |
Any hope to get this merged soon? |
Ping @chaijs/chai-jquery |
Hi all, it's been one and half years in pending approval status, let's assign directly to particular people, otherwise nobody will pick it up. |
@chaijs/chai Can we force this one through and release a new version? |
@meeber I'm happy for you to merge & release if you're comfortable doing that? LMK if you need any access for passwords or something |
Thanks @keithamus. I'll create a PR to bump the version in I'll need help with the actual This would be a good plugin for us to recruit a champion / maintainer for. I don't use |
A breaking change in Chai v4.0's
property
assertion causes thedata
assertion to fail whenever only one argument is provided. This PR fixes it.