Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Chai v4.0 #105

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Update for Chai v4.0 #105

merged 1 commit into from
Oct 15, 2018

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Dec 17, 2016

A breaking change in Chai v4.0's property assertion causes the data assertion to fail whenever only one argument is provided. This PR fixes it.

@meeber
Copy link
Contributor Author

meeber commented May 26, 2017

@keithamus I've updated this PR for the Chai 4.0 release. Although Chai v4.0 is now a dependency for the test suite (due to changes in failed assertion message text), the library should still support older versions of Chai.

@keithamus
Copy link
Member

LGTM but I'd like someone from @chaijs/chai-jquery to approve this too.

@jscharett
Copy link

Any hope to get this merged soon?

@gesellix
Copy link

Ping @chaijs/chai-jquery
Is this project also paused like chai-things? See chaijs/chai-things#58 (comment)

@revelt
Copy link

revelt commented Sep 4, 2018

Hi all, it's been one and half years in pending approval status, let's assign directly to particular people, otherwise nobody will pick it up.

@meeber
Copy link
Contributor Author

meeber commented Oct 14, 2018

@chaijs/chai Can we force this one through and release a new version?

@keithamus
Copy link
Member

@meeber I'm happy for you to merge & release if you're comfortable doing that? LMK if you need any access for passwords or something

@meeber meeber merged commit a9b66e5 into chaijs:master Oct 15, 2018
@meeber meeber deleted the chai-v4 branch October 15, 2018 20:52
@meeber
Copy link
Contributor Author

meeber commented Oct 15, 2018

Thanks @keithamus. I'll create a PR to bump the version in package.json, and draft a new release in GitHub. Let me know if there's anything else that's needed for this plugin.

I'll need help with the actual npm publish. I'm guessing my npm account doesn't have permission to do that.

This would be a good plugin for us to recruit a champion / maintainer for. I don't use jquery or chai-jquery so it's a bit awkward for me to do this, and definitely not something I want to take on long-term responsibility for. I was just deleting some old forks in my GitHub repo list when I discovered I had an old PR still open in this repo from the Chai v4.0 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants