fix: set alwayslink = True
#1385
Draft
+240
−424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait until #1389 lands, since the test fixtures will be easier after that. |
auto-merge was automatically disabled
December 9, 2024 14:48
Pull request was converted to draft
* If a modulemap needs to be generated (i.e. one isn’t provided by the target), we always generate it instead of letting rules_swift generate it for Swift targets; this ensures we have consistent and non-duplicate modulemaps * Generated modulemaps are now nested in a similar way to rules_swift, preventing them from being picked up accidentally * We no longer generate a modulemap for Swift targets, and instead use the `swift.propagate_generated_module_map` feature * We no longer create another target for the Objective-C resource module accessor; this aligns with how SPM does it and removes another target that could try to generate a modulemap * The parent target for clang targets is now only an aggregator (i.e. it doesn’t have headers of its own), preventing it from complicating the build graph * The parent target for clang targets includes the generated modulemap as a child dep, removing the need to generate a noop modulemap * When detecting a custom modulemap, we only consider the public includes paths, preventing accidentally picking up errant modulemaps Signed-off-by: Brentley Jones <[email protected]>
This matches SPM’s behavior. It’s needed to create dynamic frameworks from rspm targets. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/fix-set-alwayslink-true
branch
from
d7076ad to
1e37651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches SPM’s behavior. It’s needed to create dynamic frameworks from rspm targets.