Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: _highContrastLuminanceThreshold as string (fixes #99) #101

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix: _highContrastLuminanceThreshold as string (fixes #99) #101

merged 1 commit into from
Oct 13, 2023

Conversation

oliverfoster
Copy link
Member

fixes #99

If _highContrastLuminanceThreshold is defined as a string "70" in the json, rather than a number 70, the high contrast calculations will not be applied properly, converting all bright colours to 30% darkness.

Fix

  • Converts _highContrastLuminanceThreshold to a number

@oliverfoster oliverfoster added the bug Something isn't working label Oct 13, 2023
@oliverfoster oliverfoster self-assigned this Oct 13, 2023
guywillis
guywillis approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit ba55512 into master Oct 13, 2023
1 check passed
@oliverfoster oliverfoster deleted the issue/99 branch October 13, 2023 13:36
github-actions bot pushed a commit that referenced this pull request Oct 13, 2023
@semantic-release-bot
Chore(release): 2.5.4 [skip ci]
86ed446 
## [2.5.4](v2.5.3...v2.5.4) (2023-10-13)

### Fix

* _highContrastLuminanceThreshold as string (fixes #99) (#101) ([ba55512](ba55512)), closes [#99](#99) [#101](#101)
@github-actions
Copy link

🎉 This PR is included in version 2.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

high contrast mode displays black
2 participants
@oliverfoster @guywillis