Fix: Adds support for Visua11y's 'no animations' option (fixes #3) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashbuck
changed the title
swashbuck
changed the title
Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: Oliver Foster <[email protected]>
swashbuck
changed the title
oliverfoster
approved these changes
Sep 26, 2023
|
Beautiful. So easy to read. Thanks. |
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Fix
"_playFirstViewOnly": trueand scrolling off and back again. The frame displayed when back on screen was blank. May not be an issue (see notes).Notes
For some reason, I needed to subtract one from the total frames in order to go to the last frame.
This was causing an issue with
_playFirstViewOnlywhich has been fixed. It would be good to know if the problem was with the specific.svgzfile that I was using, or if others can reproduce the same issue.In any case, would it be safer to just stop at the 2nd to last frame in case any given
.svgzfile has the same issue? I don't know how often this issue comes up.