Generalize viewer database configuration #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit generalizes the database configuration used by the Django viewer application. Instead of assuming a SQLite database file, this commit alters the project settings to use dj-database-url [0] instead, which supports various database backends. The DATABASE_URL parameter must now specify a dj-database-url configuration string instead of a SQLite file path. Because the viewer backend now supports any database, the ability to download the raw SQLite database file has been removed from the frontend. Deployments that use SQLite as the database storage can provide alternate ways of exposing that file if needed. The crawler application still deliberately writes to a SQLite file; a subsequent PR will consolidate this with the viewer database backend by supporting storage of multiple crawls. The project README has been rewritten to better document how to run the crawler using both a Python virtual environment or Docker. [0] https://github.com/jazzband/dj-database-url
willbarton
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalizes the database configuration used by the Django viewer application. Instead of assuming a SQLite database file, this commit alters the project settings to use dj-database-url instead, which supports various database backends.
The
DATABASE_URLparameter must now specify a dj-database-url configuration string instead of a SQLite file path.Because the viewer backend now supports any database, the ability to download the raw SQLite database file has been removed from the frontend. Deployments that use SQLite as the database storage can provide alternate ways of exposing that file if needed.
The crawler application still deliberately writes to a SQLite file; a subsequent PR will consolidate this with the viewer database backend by supporting storage of multiple crawls.
The project README has been rewritten to better document how to run the crawler using both a Python virtual environment or Docker.