Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): remove cypress from codebase #1082

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Dec 10, 2024

I'm really happy with where we are with our Playwright tests, so let's get rid of the cypress tests to prevent those failures from letting us have those sweet green check marks. ✅

Currently the cypress tests fail when running on commits on main due to a missing record key. We don't need these tests anymore, and I think now is the time to get rid of them.

Screenshot 2024-12-10 at 2 24 59 PM

Closes #992

Changes

  • Removes cypress from deps, readme, package.json scripts, cache, and removes the folder of test files

How to test this PR

  1. Does the website still build and work?

Screenshots

Screenshot 2024-12-10 at 2 22 04 PM

@billhimmelsbach billhimmelsbach changed the base branch from main to test-revert-node-22 December 10, 2024 19:19
Base automatically changed from test-revert-node-22 to main December 10, 2024 19:47
@billhimmelsbach billhimmelsbach marked this pull request as ready for review December 10, 2024 22:25
@billhimmelsbach billhimmelsbach merged commit b84427e into main Dec 10, 2024
10 checks passed
@billhimmelsbach billhimmelsbach deleted the 992-remove-cypress-tests branch December 10, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove Cypress (unused)
2 participants