Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated confirmation send with expected email format #49

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Updated confirmation send with expected email format #49

merged 2 commits into from
Nov 22, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #45

@jcadam14 jcadam14 self-assigned this Nov 20, 2024
@jcadam14 jcadam14 linked an issue Nov 20, 2024 that may be closed by this pull request
Implement confirmation email. #45
Closed
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/regtech_mail_api
  internal.py
  mailer.py 77
  public.py
Project Total  

This report was generated by python-coverage-comment-action

@jcadam14 jcadam14 mentioned this pull request Nov 20, 2024
Closed
lchen-2101
lchen-2101 approved these changes Nov 22, 2024
View reviewed changes
Copy link

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 305c371 into main Nov 22, 2024
4 checks passed
@lchen-2101 lchen-2101 deleted the 45-implement-confirmation-email branch November 22, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement confirmation email.
2 participants
@jcadam14 @lchen-2101