Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1546 Made accessibility fixes to Action bar buttons #550

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Oct 1, 2024

Button colors for Action Bar may have been indirectly changed when the styling overrides were updated/taken out. Fixed the Action Bar "Export data" and "Print" buttons so that they continue to meet accessibility requirements.

New Colors:

  • Default: Dark pacific
  • Hover: Navy
  • Focus: Dark pacific + 1px dotted outline in dark pacific
  • Active: Navy + 1px dotted outline in navy

Additions

Removals

Changes

Testing

  • Go to branch DATAP-1546-Change-Action-Bar-Button-Colors
  • Run yarn start
  • Go to Action Bar to view "Export Data" and "Print" buttons
  • Use Chrome DevTools to ensure that colors match each button and their states (default, active, focus, and hover)
    Screenshot 2024-10-01 at 12 28 01 PM

Screenshots

Before
image

After
Default:
Screenshot 2024-10-01 at 12 17 37 PM

Hover:
Screenshot 2024-10-01 at 12 22 07 PM

Focus:
Screenshot 2024-10-01 at 12 22 47 PM

Active:
Screenshot 2024-10-01 at 12 20 39 PM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 October 1, 2024 16:30
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flacoman91 flacoman91 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 7cd827a Oct 1, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1546-Change-Action-Bar-Button-Colors branch October 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants