Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1548 - Aggregations api logic bug fix #547

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Sep 26, 2024

Additions

  • adding some logic so aggregations api does not get called if the same call is in progress
  • added logic to strip out size param from aggs api call since those calls are supposed to be size=0
  • added logic to complaint detail endpoint to prevent dupe calls

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@flacoman91 flacoman91 changed the title DATAP-1548 - Aggs api logic bug fix DATAP-1548 - Aggregations api logic bug fix Sep 27, 2024
@flacoman91 flacoman91 marked this pull request as ready for review September 27, 2024 13:54
@flacoman91 flacoman91 requested a review from cdmh219 September 27, 2024 13:56
@cdmh219 cdmh219 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 12b227c Sep 27, 2024
2 checks passed
@cdmh219 cdmh219 deleted the DATAP-1548-aggregations-api-bug branch September 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants