Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1541 - A11Y accessibility fixes, remove breaks from heading text #546

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Sep 26, 2024

Addresses: DATAP-1541

This is a PR to support the ongoing accessibility work.

Additions

  • Converted text to display numbers inline with text so that screenreaders will not read nbsp and line breaks will not appear

Removals

  • remove react-intl formatting library since we can do it natively with toLocaleString()

Changes

Testing

  • Run code and compare with production.
  • the numbers and formatting should visually appear the same.
  • Use the voiceover utility or screenreader. The text that is highlighted should read all in a sentence without breaks. For instance: "Showing 3,923,166 matches out of 6,220,872 total complaints"
    Examples:
    Old way
Screenshot 2024-09-26 at 5 31 49 AM

Fixed text

Screenshot 2024-09-26 at 5 31 58 AM

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

… format strings inline so voiceover doesnt choke
@flacoman91 flacoman91 marked this pull request as ready for review September 26, 2024 12:38
@flacoman91 flacoman91 requested a review from cdmh219 September 26, 2024 12:39
@flacoman91 flacoman91 changed the title DATAP-1541 - A11Y accessibility fixes DATAP-1541 - A11Y accessibility fixes, remove breaks from heading text Sep 26, 2024
@cdmh219 cdmh219 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 93a7da8 Sep 26, 2024
2 checks passed
@cdmh219 cdmh219 deleted the DATAP-1541-accessibility-fixes branch September 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants