This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Fixed bug: restore origin history state when set history. #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferdinandi
reviewed
Jan 23, 2019
| smoothScroll: JSON.stringify(options), | ||
| anchor: hash ? hash : window.pageYOffset | ||
| }; | ||
| if (history.state) { |
There was a problem hiding this comment.
I understand the bit above, but can you explain to me why this is needed?
There was a problem hiding this comment.
Look at this screen shot below, this is a SPA which is using vue and vue router.
When I push a new route, history state will automatically set by vue router, if you just replace history state, vue router will not work correctly.
If you use react router or set some state by yourself, this has the same problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use vue router or some modules which will modify history state,smooth scroll will cover origin state,this pr will fix this problem.