Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDUNITS clarifications from workshop housekeeping 2022 #390

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

davidhassell
Copy link
Contributor

@davidhassell davidhassell commented Sep 13, 2022

See issue #385 for discussion of these changes.

Also Fixes #260

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

@erget erget linked an issue Sep 13, 2022 that may be closed by this pull request
Copy link
Contributor Author

@davidhassell davidhassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of new recommadations

ch04.adoc Outdated Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
@erget
Copy link
Member

erget commented Sep 14, 2022

Looks like @davidhassell you have reviewed and implemented the changes to the PR that you proposed. Thus I have resolved the discussion around them. Are you happy for this to be merged or is this still WIP?

@erget erget merged commit c3a49e7 into cf-convention:main Sep 15, 2022
@erget
Copy link
Member

erget commented Sep 15, 2022

Sorry - these need to be rebased onto the Conventions as I should have waited for the 3w deadline to pass. I'll note that in the issue and start the countdown for 3w.

@erget
Copy link
Member

erget commented Oct 6, 2022

Just cherry-picked the commits from this reverted PR onto main

@davidhassell davidhassell added this to the 1.11 milestone Nov 27, 2023
@davidhassell davidhassell deleted the udunits-text-housekeeping branch November 27, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

udunits items udunits supports ppm, but documentation states it does not
3 participants