-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should cf_role be deprecated in favor of standard_name? #430
Comments
The only use I'm familiar with is for DSG datasets, Chapter 9.5 and all of the related examples in Appendix H that you're probably referring to. I just know that And googling just now to check xarray usage led me to cf-xarray, which is newer and maybe more easily disentangled if Personally, I like the separation/distinction from |
I do believe that both ugrid and sgrid standards, that try to be cf-compliant, use the cf_role extensively in their specifications. A deprecation cf_role would impact those two standards as well. |
Dear Dave @dblodgett-usgs Thanks for asking the question. I think the motivation for introducing The variable with the Also, it's not obvious that When discussing this, we should also keep in mind our principle 10 (in section 1.2), "Because all previous versions must generally continue to be supported in software for the sake of archived datasets, and in order to limit the complexity of the conventions, there is a strong preference against introducing any new capability to the conventions when there is already some method that can adequately serve the same purpose (even if a different method would arguably be better than the existing one)." Best wishes Jonathan |
A few notes on the UGRID, which will be in CF-1.11. As far as I know, the only mandatory use of
But the UGRID examples make extensive optional use of the attribute on connectivity variables, e.g.
There was a discussion about this over at #153, which ended in an agreement that the optional For a mesh topology variable, if we were to deprecate Thanks, |
Hi All -- I appreciate the pointers to the ugrid spec and its use of I guess the incorporation of ugrid, which makes use of I'm pretty sure we have two schools of design thought at play in the spec and just need to mention that this dichotomy exists? Or is there some logic for having a Regards -- Dave |
Dear Dave @dblodgett-usgs I agree that I think the contents of the Best wishes Jonathan |
Current Spec: (section 9.5)
I would suggest the first sentence be modified / expanded to read:
That's not very satisfying, but at least it clarifies that there are two ways it's been done? |
Dave @dblodgett-usgs and I have exchanged emails about this. As a result, we would like to propose in Section 9.5 to change
to
This change to the text would not alter the meaning of the convention. Its purpose to clarify the purpose of the Thanks Jonathan |
Thanks for following this up @JonathanGregory -- I think this is a good all around solution. |
Three weeks have passed with no further comment, so this change is accepted. Dave @dblodgett-usgs, please could you check the PR and merge if satisfactory? Thanks. |
Dear CF community,
Based on recent conversation and a number of experiences where this caused confusion, I wonder if it would be wise to deprecate the
cf_role
attribute in favor of extendedstandard_name
attributes? Scanning the spec for instances ofcf_role
I don't see any cases where astandard_name
couldn't be used instead.I ask because I have been confused about the purpose (role) of
standard_name
and thecf_role
attribute. It seems that someone introducedcf_role
with a separation of concerns between functional and quantity type in mind. Other people who have contributed did not continue using that separation of concerns for other parts of the specification.Maybe I'm missing something that forces the inclusion of
cf_role
but none of the examples show use of bothcf_role
andstandard_name
so the reason for the additional functional descriptor is not clear. If we are to keepcf_role
andstandard_name
, it would be useful to document the need for both more clearly in the specification and examples?Regards -- Dave
@JonathanGregory writes: Following discussion, Dave and I have proposed a change in order to clarify the purpose of
cf_role
. We think this change would correct a defect in the convention text but would not be a material change to the convention.@JonathanGregory writes: Pull request 434 implements this change.
The text was updated successfully, but these errors were encountered: