Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc typos and Examples (in test) with DimensionalData and Aux #79

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

virgile-baudrot
Copy link
Contributor

add examples in test, but maybe would be better to add in example of doc.

@rafaqz
Copy link
Member

rafaqz commented Jan 18, 2021

Did you want this merged? it's marked work in progress

@virgile-baudrot
Copy link
Contributor Author

Yes, my idea was to propose an example to show a simple example that convert a 3D array into a DimArray since a 3D array are no more supported as aux. So the most important is that:

suit =  reshape(
        repeat(
        [1.0 1.0 2.0;
        2.0 2.0 0.5;
        1.0 1.0 0.5],3), (3,3,3))

 suit_DD = DimArray(suit, (X, Y, Ti));

But maybe it's better within Documentation than in test, this is why I used draft PR

@rafaqz
Copy link
Member

rafaqz commented Jan 18, 2021

Ok thats better for the docs then - either DynamicGrids.jl or here, I'm not sure.

Those kinds of tests are all in DynamicGrids.jl too.

@rafaqz
Copy link
Member

rafaqz commented Jan 19, 2021

Also I would deal with those typos and the examples separately, good to just get those fixes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants