Add support for PodMonitor

[shlomitubul]

Add support for using PodMonitor

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jetstack-bot]

Hi @shlomitubul. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[erikgb]

Hi @shlomitubul! Can you explain why you cannot use a ServiceMonitor? This PR adds a lot of additional complexity, and ServiceMonitor and PodMonitor are quite equivalent in function, ref. prometheus-operator/prometheus-operator#3119.

[shlomitubul]

@erikgb we want to reduce the use of k8s service when it's not needed as the metrics service only exists to give ServiceMonitor access

[shlomitubul]

@erikgb is there anything from my end that need to be handled ?

[erikgb]

@erikgb is there anything from my end that need to be handled ?

I would personally solve your use case (minimize the number of services) differently. Since trust-manager already has a webhook service, I would use this service to scrape metrics also. And keep the ServiceMonitor - to reduce Helm chart complexities. But I'll leave the decision to the maintainers. Maybe @inteon has an opinion?

[cert-manager-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

[cert-manager-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
/remove-lifecycle stale