Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[webpack-config-terra][terra-aggregate-translations] MVB updates #860

Merged
merged 13 commits into from
May 1, 2024

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Apr 25, 2024

Summary

This PR:

  • Updates webpack-config-terra to use terra-aggregate-translations@3.
  • Removes overriding of default locales in terra-aggregate-translations. From now on, only the internal list of locales will be used for translations. This is due api changes in react-intl and webpack limitations.
  • Drops support for Node 10 & 12 for both these packages as these versions have long been deprecated.

These changes were done to support the terra-application v2 changes in cerner/terra-application#293.

Upgrade guides for these breaking changes will be added in an upcoming PR.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-860 April 26, 2024 14:47 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-860 April 26, 2024 15:07 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-860 May 1, 2024 15:32 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-860 May 1, 2024 15:34 Destroyed
@sdadn sdadn merged commit 54e92e1 into main May 1, 2024
6 checks passed
@sdadn sdadn deleted the webpack-config-terra-MVB-v4 branch May 1, 2024 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants