Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[stylelint-config-terra] removing extra dependencies #841

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Jan 31, 2024

Summary

This PR removes the following extraneous dependencies from stylelint-config-terra:

  • stylelint-scss: is already added as part of stylelint-config-sass-guidelines.
  • stylelint-order: is unused as it is not imported anywhere or added as a plugin.

CleanShot 2024-01-31 at 15 49 29

These packages were removed to resolve the following "conflicting peer dependencies" errors when installing.

CleanShot 2024-01-31 at 15 50 17

CleanShot 2024-01-31 at 15 50 07

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

The change was testing by installing it locally on terra-framework and running the lint:scss script which successfully ran without giving any additional errors (same output as main):

CleanShot 2024-01-31 at 15 52 41

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Jan 31, 2024
@sdadn sdadn requested a review from a team as a code owner January 31, 2024 22:03
@github-actions github-actions bot temporarily deployed to preview-pr-841 January 31, 2024 22:19 Destroyed
@sdadn sdadn merged commit 95b51b1 into main Jan 31, 2024
6 checks passed
@sdadn sdadn deleted the update-stylelint-config-terra branch January 31, 2024 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants