This repository has been archived by the owner on May 22, 2024. It is now read-only.
Add babel-plugin-syntax-dynamic-import to terra-toolkit #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLaCombe
requested review from
bjankord,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
bjankord
approved these changes
Jan 7, 2019
|
Has this been verified in our repos? Are there an any downstream affects for adding this in projects that are using require.ensure instead of dynamic imports? |
|
I've tested it in terra-core and terra-framework, and it appears to be building just fine. I ran it in IE11 as well, and I don't see any issues while accessing some of the packages that need translations. |
emilyrohrbough
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #201